Feature/system ntp status - #335
Merged
SuperQ merged 4 commits intoNov 6, 2025
Merged
Conversation
Signed-off-by: Örnfeldt Philip (66140321) <philip.ornfeldt@forsakringskassan.se>
Signed-off-by: Örnfeldt Philip (66140321) <philip.ornfeldt@forsakringskassan.se>
Signed-off-by: Örnfeldt Philip (66140321) <philip.ornfeldt@forsakringskassan.se>
Philldomd
force-pushed
the
feature/system-ntp-status
branch
from
September 15, 2025 13:24
6dd3d77 to
627992f
Compare
SuperQ
requested changes
Oct 21, 2025
Contributor
|
Maybe take a look at the Prometheus best practices docs: https://prometheus.io/docs/practices/naming/ |
Signed-off-by: Örnfeldt Philip (66140321) <philip.ornfeldt@forsakringskassan.se>
SuperQ
reviewed
Nov 5, 2025
SuperQ
approved these changes
Nov 5, 2025
SuperQ
left a comment
SuperQ
left a comment
Contributor
There was a problem hiding this comment.
Minor nit, otherwise LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added probe for ntp status